fix potential timing attacks in rsa, eax, ocb and ocb3

This commit is contained in:
Steffen Jaeckel 2017-06-20 15:55:35 +02:00
parent b03b93099d
commit 05e28d6cfa
4 changed files with 4 additions and 4 deletions

View File

@ -82,7 +82,7 @@ int eax_decrypt_verify_memory(int cipher,
} }
/* compare tags */ /* compare tags */
if (buflen >= taglen && XMEMCMP(buf, tag, taglen) == 0) { if (buflen >= taglen && XMEM_NEQ(buf, tag, taglen) == 0) {
*stat = 1; *stat = 1;
} }

View File

@ -55,7 +55,7 @@ int ocb_done_decrypt(ocb_state *ocb,
goto LBL_ERR; goto LBL_ERR;
} }
if (taglen <= tagbuflen && XMEMCMP(tagbuf, tag, taglen) == 0) { if (taglen <= tagbuflen && XMEM_NEQ(tagbuf, tag, taglen) == 0) {
*stat = 1; *stat = 1;
} }

View File

@ -87,7 +87,7 @@ int ocb3_decrypt_verify_memory(int cipher,
} }
/* compare tags */ /* compare tags */
if (buflen >= taglen && XMEMCMP(buf, tag, taglen) == 0) { if (buflen >= taglen && XMEM_NEQ(buf, tag, taglen) == 0) {
*stat = 1; *stat = 1;
} }

View File

@ -163,7 +163,7 @@ int rsa_verify_hash_ex(const unsigned char *sig, unsigned long siglen,
} else { } else {
/* only check if the hash is equal */ /* only check if the hash is equal */
if ((hashlen == outlen) && if ((hashlen == outlen) &&
(XMEMCMP(out, hash, hashlen) == 0)) { (XMEM_NEQ(out, hash, hashlen) == 0)) {
*stat = 1; *stat = 1;
} }
} }