TeaSpeak/tomcrypt
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fir coverity finding: dsa_import double free

Browse Source
This commit is contained in:
Karel Miko 2017-02-24 21:13:22 +01:00
parent 6499c70492
commit 1e260eeaae
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/pk/dsa/dsa_import.c
View File

@ -103,10 +103,12 @@ int dsa_import(const unsigned char *in, unsigned long inlen, dsa_key *key)
PKA_DSA, tmpbuf, &tmpbuf_len, PKA_DSA, tmpbuf, &tmpbuf_len,
LTC_ASN1_SEQUENCE, params, 3); LTC_ASN1_SEQUENCE, params, 3);
if (err != CRYPT_OK) { if (err != CRYPT_OK) {
XFREE(tmpbuf);
goto LBL_ERR; goto LBL_ERR;
} }
if ((err=der_decode_integer(tmpbuf, tmpbuf_len, key->y)) != CRYPT_OK) { if ((err=der_decode_integer(tmpbuf, tmpbuf_len, key->y)) != CRYPT_OK) {
XFREE(tmpbuf);
goto LBL_ERR; goto LBL_ERR;
} }
@ -125,7 +127,6 @@ LBL_OK:
return CRYPT_OK; return CRYPT_OK;
LBL_ERR: LBL_ERR:
XFREE(tmpbuf);
mp_clear_multi(key->p, key->g, key->q, key->x, key->y, NULL); mp_clear_multi(key->p, key->g, key->q, key->x, key->y, NULL);
return err; return err;
} }