TeaSpeak/tomcrypt
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

rsa_import: prevent double-free

Browse Source
This commit is contained in:
Steffen Jaeckel 2012-04-24 18:08:13 +02:00
parent 5c9fa403ff
commit 2cd666f284
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/pk/rsa/rsa_import.c
View File

@ -62,11 +62,10 @@ int rsa_import(const unsigned char *in, unsigned long inlen, rsa_key *key)
LTC_ASN1_EOL, 0UL, NULL)) != CRYPT_OK) { LTC_ASN1_EOL, 0UL, NULL)) != CRYPT_OK) {
goto LBL_ERR; goto LBL_ERR;
} }
XFREE(tmpbuf);
key->type = PK_PUBLIC; key->type = PK_PUBLIC;
return CRYPT_OK; err = CRYPT_OK;
goto LBL_FREE;
} }
XFREE(tmpbuf);
/* not SSL public key, try to match against LTC_PKCS #1 standards */ /* not SSL public key, try to match against LTC_PKCS #1 standards */
if ((err = der_decode_sequence_multi(in, inlen, if ((err = der_decode_sequence_multi(in, inlen,
@ -110,10 +109,16 @@ int rsa_import(const unsigned char *in, unsigned long inlen, rsa_key *key)
} }
key->type = PK_PUBLIC; key->type = PK_PUBLIC;
} }
return CRYPT_OK; err = CRYPT_OK;
goto LBL_FREE;
LBL_ERR: LBL_ERR:
XFREE(tmpbuf);
mp_clear_multi(key->d, key->e, key->N, key->dQ, key->dP, key->qP, key->p, key->q, NULL); mp_clear_multi(key->d, key->e, key->N, key->dQ, key->dP, key->qP, key->p, key->q, NULL);
LBL_FREE:
if (tmpbuf != NULL)
XFREE(tmpbuf);
return err; return err;
} }