mirror of
https://github.com/f4exb/sdrangel.git
synced 2026-07-26 12:04:13 -04:00
Robin Getz
95548a92aa
Correct std::fill() calls in SPHP::flush() that used x0.end() as the end iterator when clearing x1, y0, and y1. The incorrect ranges were likely introduced by a copy/paste error and resulted in iterator pairs from different containers being used together, causing undefined behavior. Use each buffer's own end iterator when clearing its contents. Detected by cppcheck's mismatchingContainer check. Signed-off-by: Robin Getz <rgetz503@gmail.com>
131 lines
3.4 KiB
C++
131 lines
3.4 KiB
C++
/* iir.c
|
|
|
|
This file is part of a program that implements a Software-Defined Radio.
|
|
|
|
Copyright (C) 2014, 2022, 2023 Warren Pratt, NR0V
|
|
Copyright (C) 2024 Edouard Griffiths, F4EXB Adapted to SDRangel
|
|
|
|
This program is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU General Public License
|
|
as published by the Free Software Foundation; either version 2
|
|
of the License, or (at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
|
|
The author can be reached by email at
|
|
|
|
warren@wpratt.com
|
|
|
|
*/
|
|
|
|
#include "comm.hpp"
|
|
#include "sphp.hpp"
|
|
|
|
namespace WDSP {
|
|
|
|
/********************************************************************************************************
|
|
* *
|
|
* Complex Single-Pole High-Pass *
|
|
* *
|
|
********************************************************************************************************/
|
|
|
|
void SPHP::calc()
|
|
{
|
|
double g;
|
|
x0.resize(nstages * 2); // (float*)malloc0(nstages * sizeof(complex));
|
|
x1.resize(nstages * 2); // (float*)malloc0(nstages * sizeof(complex));
|
|
y0.resize(nstages * 2); // (float*)malloc0(nstages * sizeof(complex));
|
|
y1.resize(nstages * 2); // (float*)malloc0(nstages * sizeof(complex));
|
|
g = exp(-TWOPI * fc / rate);
|
|
b0 = +0.5 * (1.0 + g);
|
|
b1 = -0.5 * (1.0 + g);
|
|
a1 = -g;
|
|
}
|
|
|
|
SPHP::SPHP(
|
|
int _run,
|
|
int _size,
|
|
float* _in,
|
|
float* _out,
|
|
double _rate,
|
|
double _fc,
|
|
int _nstages
|
|
) :
|
|
run(_run),
|
|
size(_size),
|
|
in(_in),
|
|
out(_out),
|
|
rate(_rate),
|
|
fc(_fc),
|
|
nstages(_nstages)
|
|
{
|
|
calc();
|
|
}
|
|
|
|
void SPHP::flush()
|
|
{
|
|
std::fill(x0.begin(), x0.end(), 0);
|
|
std::fill(x1.begin(), x1.end(), 0);
|
|
std::fill(y0.begin(), y0.end(), 0);
|
|
std::fill(y1.begin(), y1.end(), 0);
|
|
}
|
|
|
|
void SPHP::execute()
|
|
{
|
|
if (run)
|
|
{
|
|
for (int i = 0; i < size; i++)
|
|
{
|
|
for (int j = 0; j < 2; j++)
|
|
{
|
|
x0[j] = in[2 * i + j];
|
|
|
|
for (int n = 0; n < nstages; n++)
|
|
{
|
|
if (n > 0)
|
|
x0[2 * n + j] = y0[2 * (n - 1) + j];
|
|
|
|
y0[2 * n + j] = b0 * x0[2 * n + j]
|
|
+ b1 * x1[2 * n + j]
|
|
- a1 * y1[2 * n + j];
|
|
y1[2 * n + j] = y0[2 * n + j];
|
|
x1[2 * n + j] = x0[2 * n + j];
|
|
}
|
|
|
|
out[2 * i + j] = (float) y0[2 * (nstages - 1) + j];
|
|
}
|
|
}
|
|
}
|
|
else if (out != in)
|
|
{
|
|
std::copy(in, in + size * 2, out);
|
|
}
|
|
}
|
|
|
|
void SPHP::setBuffers(float* _in, float* _out)
|
|
{
|
|
in = _in;
|
|
out = _out;
|
|
}
|
|
|
|
void SPHP::setSamplerate(int _rate)
|
|
{
|
|
rate = _rate;
|
|
calc();
|
|
}
|
|
|
|
void SPHP::setSize(int _size)
|
|
{
|
|
size = _size;
|
|
flush();
|
|
}
|
|
|
|
} // namespace WDSP
|