diff --git a/src/process/FFTDataDistributor.cpp b/src/process/FFTDataDistributor.cpp index 07a6a3d..0b9c17e 100644 --- a/src/process/FFTDataDistributor.cpp +++ b/src/process/FFTDataDistributor.cpp @@ -21,7 +21,7 @@ void FFTDataDistributor::setLinesPerSecond(unsigned int lines) { this->linesPerSecond = lines; } -unsigned int FFTDataDistributor::getLinesPerSecond() { +unsigned int FFTDataDistributor::getLinesPerSecond() const { return this->linesPerSecond; } diff --git a/src/process/FFTDataDistributor.h b/src/process/FFTDataDistributor.h index 9f60288..452ab87 100644 --- a/src/process/FFTDataDistributor.h +++ b/src/process/FFTDataDistributor.h @@ -14,12 +14,12 @@ public: FFTDataDistributor(); void setFFTSize(unsigned int size); void setLinesPerSecond(unsigned int lines); - unsigned int getLinesPerSecond(); + unsigned int getLinesPerSecond() const; protected: - virtual void process(); + void process() override; - DemodulatorThreadIQData inputBuffer, tempBuffer; + DemodulatorThreadIQData inputBuffer; ReBuffer outputBuffers; std::atomic fftSize; diff --git a/src/process/FFTVisualDataThread.cpp b/src/process/FFTVisualDataThread.cpp index 0dd398e..8961239 100644 --- a/src/process/FFTVisualDataThread.cpp +++ b/src/process/FFTVisualDataThread.cpp @@ -2,16 +2,13 @@ // SPDX-License-Identifier: GPL-2.0+ #include "FFTVisualDataThread.h" -#include "CubicSDR.h" FFTVisualDataThread::FFTVisualDataThread() { linesPerSecond.store(DEFAULT_WATERFALL_LPS); lpsChanged.store(true); } -FFTVisualDataThread::~FFTVisualDataThread() { - -} +FFTVisualDataThread::~FFTVisualDataThread() = default; void FFTVisualDataThread::setLinesPerSecond(int lps) { linesPerSecond.store(lps); diff --git a/src/process/FFTVisualDataThread.h b/src/process/FFTVisualDataThread.h index 549950b..6d2b53b 100644 --- a/src/process/FFTVisualDataThread.h +++ b/src/process/FFTVisualDataThread.h @@ -10,15 +10,15 @@ class FFTVisualDataThread : public IOThread { public: FFTVisualDataThread(); - ~FFTVisualDataThread(); + ~FFTVisualDataThread() override; void setLinesPerSecond(int lps); int getLinesPerSecond(); SpectrumVisualProcessor *getProcessor(); - virtual void run(); + void run() override; - virtual void terminate(); + void terminate() override; protected: FFTDataDistributor fftDistrib; diff --git a/src/process/ScopeVisualProcessor.cpp b/src/process/ScopeVisualProcessor.cpp index a1eefac..3ee4691 100644 --- a/src/process/ScopeVisualProcessor.cpp +++ b/src/process/ScopeVisualProcessor.cpp @@ -3,7 +3,6 @@ #include "ScopeVisualProcessor.h" #include -#include ScopeVisualProcessor::ScopeVisualProcessor(): outputBuffers("ScopeVisualProcessorBuffers") { scopeEnabled.store(true); diff --git a/src/process/ScopeVisualProcessor.h b/src/process/ScopeVisualProcessor.h index 0cd5a44..e9417e0 100644 --- a/src/process/ScopeVisualProcessor.h +++ b/src/process/ScopeVisualProcessor.h @@ -19,9 +19,7 @@ public: int fft_size; double fft_floor, fft_ceil; - virtual ~ScopeRenderData() { - - } + virtual ~ScopeRenderData() = default; }; typedef std::shared_ptr ScopeRenderDataPtr; @@ -33,12 +31,12 @@ typedef std::shared_ptr ScopeRenderDataQueuePtr; class ScopeVisualProcessor : public VisualProcessor { public: ScopeVisualProcessor(); - ~ScopeVisualProcessor(); + ~ScopeVisualProcessor() override; void setup(int fftSize_in); void setScopeEnabled(bool scopeEnable); void setSpectrumEnabled(bool spectrumEnable); protected: - virtual void process(); + void process() override; ReBuffer outputBuffers; std::atomic_bool scopeEnabled; diff --git a/src/process/SpectrumVisualDataThread.cpp b/src/process/SpectrumVisualDataThread.cpp index 5841f52..0a59f71 100644 --- a/src/process/SpectrumVisualDataThread.cpp +++ b/src/process/SpectrumVisualDataThread.cpp @@ -2,14 +2,10 @@ // SPDX-License-Identifier: GPL-2.0+ #include "SpectrumVisualDataThread.h" -#include "CubicSDR.h" -SpectrumVisualDataThread::SpectrumVisualDataThread() { -} +SpectrumVisualDataThread::SpectrumVisualDataThread() = default; -SpectrumVisualDataThread::~SpectrumVisualDataThread() { - -} +SpectrumVisualDataThread::~SpectrumVisualDataThread() = default; SpectrumVisualProcessor *SpectrumVisualDataThread::getProcessor() { return &sproc; diff --git a/src/process/SpectrumVisualDataThread.h b/src/process/SpectrumVisualDataThread.h index 0c3eccf..b0fc375 100644 --- a/src/process/SpectrumVisualDataThread.h +++ b/src/process/SpectrumVisualDataThread.h @@ -9,12 +9,12 @@ class SpectrumVisualDataThread : public IOThread { public: SpectrumVisualDataThread(); - ~SpectrumVisualDataThread(); + ~SpectrumVisualDataThread() override; SpectrumVisualProcessor *getProcessor(); - virtual void run(); + void run() override; - virtual void terminate(); + void terminate() override; protected: SpectrumVisualProcessor sproc; diff --git a/src/process/SpectrumVisualProcessor.cpp b/src/process/SpectrumVisualProcessor.cpp index 74b4a26..94f0e35 100644 --- a/src/process/SpectrumVisualProcessor.cpp +++ b/src/process/SpectrumVisualProcessor.cpp @@ -201,11 +201,11 @@ unsigned int SpectrumVisualProcessor::getFFTSize() { } -void SpectrumVisualProcessor::setHideDC(bool hideDC) { +void SpectrumVisualProcessor::setHideDC(bool hideDC_in) { std::lock_guard < std::mutex > busy_lock(busy_run); - this->hideDC = hideDC; + hideDC = hideDC_in; } @@ -274,7 +274,7 @@ void SpectrumVisualProcessor::process() { std::vector *data = &iqData->data; - if (data && data->size()) { + if (data && !data->empty()) { unsigned int num_written; long resampleBw = iqData->sampleRate; bool newResampler = false; diff --git a/src/process/SpectrumVisualProcessor.h b/src/process/SpectrumVisualProcessor.h index f40069c..c66d737 100644 --- a/src/process/SpectrumVisualProcessor.h +++ b/src/process/SpectrumVisualProcessor.h @@ -19,7 +19,7 @@ public: long long centerFreq; int bandwidth; - virtual ~SpectrumVisualData() {}; + virtual ~SpectrumVisualData() = default;; }; typedef std::shared_ptr SpectrumVisualDataPtr; @@ -29,7 +29,7 @@ typedef std::shared_ptr SpectrumVisualDataQueuePtr; class SpectrumVisualProcessor : public VisualProcessor { public: SpectrumVisualProcessor(); - ~SpectrumVisualProcessor(); + ~SpectrumVisualProcessor() override; bool isView(); void setView(bool bView); @@ -52,13 +52,13 @@ public: void setup(unsigned int fftSize); void setFFTSize(unsigned int fftSize); unsigned int getFFTSize(); - void setHideDC(bool hideDC); + void setHideDC(bool hideDC_in); void setScaleFactor(float sf); float getScaleFactor(); protected: - virtual void process(); + void process() override; ReBuffer outputBuffers; diff --git a/src/process/VisualProcessor.h b/src/process/VisualProcessor.h index 904ca8b..5b0fd26 100644 --- a/src/process/VisualProcessor.h +++ b/src/process/VisualProcessor.h @@ -24,8 +24,7 @@ public: typedef std::shared_ptr VisualInputQueueTypePtr; typedef std::shared_ptr VisualOutputQueueTypePtr; - virtual ~VisualProcessor() { - } + virtual ~VisualProcessor(); bool isInputEmpty() { std::lock_guard < std::mutex > busy_lock(busy_update); @@ -155,6 +154,9 @@ protected: std::mutex busy_update; }; +template +VisualProcessor::~VisualProcessor() = default; + //Specialization much like VisualDataReDistributor, except //the input (pointer) is directly re-dispatched //to outputs, so that all output indeed SHARE the same instance.