VE7UWU/sdrangel
1
0
Fork 0
mirror of https://github.com/f4exb/sdrangel.git synced 2026-07-25 19:44:12 -04:00
Code Issues Projects Releases Wiki Activity

VOR Localizer: initialize intersection variables

Browse Source 
Initialize the coordinate and bearing variables used by
VORModel::findIntersection() and declare the validity flags as bool.

Coverity reported that lat1, lon1, bearing1, lat2, lon2, and bearing2
could be passed uninitialized to calcIntersectionPoint(). While the
current control flow is intended to assign these values before the
corresponding validity flag is set, they were not initialized at
declaration, leaving undefined behavior if that invariant were ever
broken.

Initializing the variables removes the possibility of using
indeterminate values, satisfies static analysis, and makes the code
more robust against future modifications. The validity flags are also
changed from float to bool to match their intended use.

Signed-off-by: Robin Getz <rgetz503@gmail.com>
This commit is contained in:
Robin Getz
2026-07-20 17:25:57 -04:00
parent 1270f27ebf
commit 0659f264aa
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/feature/vorlocalizer/vorlocalizergui.cpp
+4 -2
View File
@@ -304,8 +304,10 @@ bool VORModel::findIntersection(float &lat, float &lon)
{
if (m_vors.count() > 2)
{
float lat1, lon1, bearing1, valid1 = false;
float lat2, lon2, bearing2, valid2 = false;
float lat1 = 0.0f, lon1 = 0.0f, bearing1 = 0.0f;
bool valid1 = false;
float lat2 = 0.0f, lon2 = 0.0f, bearing2 = 0.0f;
bool valid2 = false;
for (int i = 0; i < m_vors.count(); i++)
{