mirror of
https://github.com/f4exb/sdrangel.git
synced 2026-07-25 19:44:12 -04:00
Robin Getz
0659f264aa
Initialize the coordinate and bearing variables used by VORModel::findIntersection() and declare the validity flags as bool. Coverity reported that lat1, lon1, bearing1, lat2, lon2, and bearing2 could be passed uninitialized to calcIntersectionPoint(). While the current control flow is intended to assign these values before the corresponding validity flag is set, they were not initialized at declaration, leaving undefined behavior if that invariant were ever broken. Initializing the variables removes the possibility of using indeterminate values, satisfies static analysis, and makes the code more robust against future modifications. The validity flags are also changed from float to bool to match their intended use. Signed-off-by: Robin Getz <rgetz503@gmail.com>